Launchpad itself

Code review comment for lp:~stevenk/launchpad/populate-spr-changelogs

  1. populate-spr-changelogs
  2. Merge into devel
Revision history for this message
William Grant (wgrant) wrote :

Looks good, but could you elaborate on the sampledata suckage? It's not at all obvious to anyone.

I'm also tempted to ask you to rename getCandidateSPRs back to getCandidateSPRIDs, since your change to make it return SPRs failed. But I think you might injure me, so I won't force the issue.

review: Approve (code*)

« Back to merge proposal