Merge lp:~stevenk/launchpad/hack-itemwidget into lp:launchpad
Status: | Merged |
---|---|
Approved by: | William Grant |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15183 |
Proposed branch: | lp:~stevenk/launchpad/hack-itemwidget |
Merge into: | lp:launchpad |
Diff against target: |
105 lines (+29/-13) 3 files modified
lib/lp/app/widgets/itemswidgets.py (+5/-2) lib/lp/app/widgets/tests/test_itemswidgets.py (+23/-11) lib/lp/registry/vocabularies.py (+1/-0) |
To merge this branch: | bzr merge lp:~stevenk/launchpad/hack-itemwidget |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
William Grant | code | Approve | |
Review via email: mp+104202@code.launchpad.net |
Commit message
Use term.description if it exists in LaunchpadRadioW
Description of the change
Currently, if both show_informatio
I have tracked this down to the widget itself, and the slightly funky behaviour we have due to the vocab being backed by an enum, and as such, the widget will use term.description if it is set, otherwise falls back to term.value.
I have done a drive-by of fixing the imports in test_itemswidgets.