Code review comment for lp:~stevenk/launchpad/denorm-bspph-model

Revision history for this message
William Grant (wgrant) wrote :

8 + sourcepackagenameID = Attribute(
9 + "The DB id for the sourcepackagename.")
10 + sourcepackagename = Int(
11 + title=_('The source package name being published'),
12 + required=False, readonly=False,
13 + )

Lies. I think you have those types the wrong way around.

There's also already SPPH.source_package_name, which delegates to SPR.name. Might want to clarify with comments what the difference is.

Same with the binary equivalents for both comments.

review: Needs Fixing

« Back to merge proposal