Code review comment for lp:~stevenk/launchpad/bpb-currentcomponent-assertion-part-3

Revision history for this message
Graham Binns (gmb) wrote :

This method is crying out for some comments explaining what it's actually doing and why. I mean, I get that it's setting things up for later tests, but it took me a couple of goes to understand what each bit does. If you can add comments to explain it a bit better, that'd be great.

538 + def setUp(self):
539 + super(TestDistributionHasBuildRecords, self).setUp()
540 + self.admin = getUtility(IPersonSet).getByEmail(ADMIN_EMAIL)
541 + self.pf_one = self.factory.makeProcessorFamily()
542 + pf_proc_1 = self.pf_one.addProcessor(
543 + self.factory.getUniqueString(), '', '')
544 + self.pf_two = self.factory.makeProcessorFamily()
545 + pf_proc_2 = self.pf_two.addProcessor(
546 + self.factory.getUniqueString(), '', '')
547 + self.distroseries = self.factory.makeDistroSeries()
548 + self.distribution = self.distroseries.distribution
549 + self.das_one = self.factory.makeDistroArchSeries(
550 + distroseries=self.distroseries, processorfamily=self.pf_one,
551 + supports_virtualized=True)
552 + self.das_two = self.factory.makeDistroArchSeries(
553 + distroseries=self.distroseries, processorfamily=self.pf_two,
554 + supports_virtualized=True)
555 + self.archive = self.factory.makeArchive(
556 + distribution=self.distroseries.distribution,
557 + purpose=ArchivePurpose.PRIMARY)
558 + self.arch_ids = [arch.id for arch in self.distroseries.architectures]
559 + with person_logged_in(self.admin):
560 + self.publisher = SoyuzTestPublisher()
561 + self.publisher.prepareBreezyAutotest()
562 + self.distroseries.nominatedarchindep = self.das_one
563 + self.publisher.addFakeChroots(distroseries=self.distroseries)
564 + self.builder_one = self.factory.makeBuilder(processor=pf_proc_1)
565 + self.builder_two = self.factory.makeBuilder(processor=pf_proc_2)
566 + self.builds = []
567 + self.createBuilds()

Also, bigjool's concerns on IRC need to be dealt with.

review: Needs Fixing (code)

« Back to merge proposal