This method is crying out for some comments explaining what it's actually doing and why. I mean, I get that it's setting things up for later tests, but it took me a couple of goes to understand what each bit does. If you can add comments to explain it a bit better, that'd be great.
This method is crying out for some comments explaining what it's actually doing and why. I mean, I get that it's setting things up for later tests, but it took me a couple of goes to understand what each bit does. If you can add comments to explain it a bit better, that'd be great.
538 + def setUp(self): ibutionHasBuild Records, self).setUp() IPersonSet) .getByEmail( ADMIN_EMAIL) makeProcessorFa mily() one.addProcesso r( getUniqueString (), '', '') makeProcessorFa mily() two.addProcesso r( getUniqueString (), '', '') makeDistroSerie s() es.distribution makeDistroArchS eries( self.distroseri es, processorfamily =self.pf_ one, virtualized= True) makeDistroArchS eries( self.distroseri es, processorfamily =self.pf_ two, virtualized= True) makeArchive( self.distroseri es.distribution , ArchivePurpose. PRIMARY) es.architecture s] logged_ in(self. admin): her() prepareBreezyAu totest( ) es.nominatedarc hindep = self.das_one addFakeChroots( distroseries= self.distroseri es) makeBuilder( processor= pf_proc_ 1) makeBuilder( processor= pf_proc_ 2)
539 + super(TestDistr
540 + self.admin = getUtility(
541 + self.pf_one = self.factory.
542 + pf_proc_1 = self.pf_
543 + self.factory.
544 + self.pf_two = self.factory.
545 + pf_proc_2 = self.pf_
546 + self.factory.
547 + self.distroseries = self.factory.
548 + self.distribution = self.distroseri
549 + self.das_one = self.factory.
550 + distroseries=
551 + supports_
552 + self.das_two = self.factory.
553 + distroseries=
554 + supports_
555 + self.archive = self.factory.
556 + distribution=
557 + purpose=
558 + self.arch_ids = [arch.id for arch in self.distroseri
559 + with person_
560 + self.publisher = SoyuzTestPublis
561 + self.publisher.
562 + self.distroseri
563 + self.publisher.
564 + self.builder_one = self.factory.
565 + self.builder_two = self.factory.
566 + self.builds = []
567 + self.createBuilds()
Also, bigjool's concerns on IRC need to be dealt with.