Code review comment for lp:~stevanr/linaro-license-protection/phpunit-tests

Thanks for working on this, Stevan.

First of, please try to follow the existing coding style for the code you are modifying. Existing code is using tabs (uhm, we should change that to 4-spaces like we do in the rest of Infrastructure projects, but that's a separate branch: do not, under any circumstances, do it in this branch).

For the python test failures you are seeing, please file a bug if there isn't one already (on the https://launchpad.net/linaro-license-protection project: there isn't one, so please do that).

Unfortunately, phpunit package is broken in Debian/Ubuntu (bug #701544), so we will have to include the workaround installation in the documentation until package itself is fixed (I expect it might only be fixed in 12.10, unless someone invests a lot of effort in fixing the 12.04 package as well, though that might be worth it considering it's an LTS).

For the function that is not used, please remove it altogether.

Next, I'll comment on the code changes directly.