Code review comment for lp:~stevanr/linaro-license-protection/phpunit-tests

Revision history for this message
Georgy Redkozubov (gesha) wrote :

1) Please revert your changes in 'testing/test_click_through_license.py' back.
2) Add instructions how to install PHP_CodeCoverage, I had to follow following steps to get running your test:
sudo apt-get remove phpunit
sudo apt-get upgrade pear
sudo pear channel-discover pear.phpunit.de
sudo pear channel-discover pear.symfony-project.com
sudo pear channel-discover components.ez.no
sudo pear update-channels
sudo pear upgrade-all
sudo pear install --alldeps phpunit/PHPUnit
sudo apt-get install phpunit
3) You have incorrect expected value for file.with.more.dots, should be:
$this->assertEquals("file", $filename_array[0]);
$this->assertEquals("with.more.dots", $filename_array[1]);

review: Needs Fixing

« Back to merge proposal