Merge lp:~stevanr/linaro-ci-dashboard/lava-install into lp:linaro-ci-dashboard

Proposed by Stevan Radaković
Status: Merged
Merged at revision: 66
Proposed branch: lp:~stevanr/linaro-ci-dashboard/lava-install
Merge into: lp:linaro-ci-dashboard
Diff against target: 0 lines
To merge this branch: bzr merge lp:~stevanr/linaro-ci-dashboard/lava-install
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Linaro Infrastructure Pending
Review via email: mp+125519@code.launchpad.net

Description of the change

Add lava install/start/stop custom command and update README.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

If you think we need to do some setup in lava post-install (add some users, or somehow import some tests) let's discuss it.

57. By Stevan Radaković

Clean up some legacy imports and comments.

Revision history for this message
Stevan Radaković (stevanr) wrote :

Also we might do something like this http://lava.readthedocs.org/en/latest/qemu-deploy.html scripted-like, but maybe it's an overkill. This has to be done only once if the user doesn't uninstall his instance, so maybe I'll add it to README for now and we can discuss tomorrow about the rest.

58. By Stevan Radaković

Add some more info to README.

Revision history for this message
Milo Casagrande (milo) wrote :

> If you think we need to do some setup in lava post-install (add some users, or
> somehow import some tests) let's discuss it.

It could be good to have one, because we will need to "play" with the token authorization in order to send jobs to LAVA. But it can be something to be done at a later stage.

Another thing that might be good to have is to import some "bundles", otherwise the LAVA install is totally empty. It is possible to do that via the lava-tool command (you can get a bundle from validation.l.o and upload it into the local instance).

Revision history for this message
Milo Casagrande (milo) wrote :

> Also we might do something like this http://lava.readthedocs.org/en/latest
> /qemu-deploy.html scripted-like, but maybe it's an overkill. This has to be
> done only once if the user doesn't uninstall his instance, so maybe I'll add
> it to README for now and we can discuss tomorrow about the rest.

Well... that would be an overkill I guess for now.
Also, do we really need to make tests run locally? We might just want to import some data in order to use it for development, and in case update that data with more recent one taken from validation.l.o.

Revision history for this message
Milo Casagrande (milo) wrote :

Took a shot at installing and running LAVA from inside the ci-dashboard, and it looks good.
One thing though: maybe add something in the HACKING file. When you run it, it asks you for your "sudo" password, might be better to know why it needs it. Also, better to give a link for the LAVA docs.

Overall it looks good to me, so approving, just add those while merging.
Thanks!

review: Approve
59. By Stevan Radaković

Add some more info into the HACKING file as per code review.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches