Code review comment for lp:~stevanr/linaro-ci-dashboard/lava-install

Revision history for this message
Milo Casagrande (milo) wrote :

Took a shot at installing and running LAVA from inside the ci-dashboard, and it looks good.
One thing though: maybe add something in the HACKING file. When you run it, it asks you for your "sudo" password, might be better to know why it needs it. Also, better to give a link for the LAVA docs.

Overall it looks good to me, so approving, just add those while merging.
Thanks!

review: Approve

« Back to merge proposal