Code review comment for lp:~stephane-duchesneau/ubuntu/trusty/pexpect/errno_handling_fix

Hi, thank you for your extensive answer, I will work on my "quilt" skills and try to follow the SRU.

--
Stéphane Duchesneau
Savoir-faire Linux

----- Mail original -----

De: "Barry Warsaw" <email address hidden>
À: <email address hidden>
Envoyé: Jeudi 8 Mai 2014 15:50:12
Objet: Re: [Merge] lp:~stephane-duchesneau/ubuntu/trusty/pexpect/errno_handling_fix into lp:ubuntu/trusty/pexpect

Hi Stéphane. First, thanks very much for your contribution to Ubuntu!

There's a bit of a problem with your merge proposal. As you'll see in the diff, it is including the .pc directory. This usually happens when the quilt patch stack for your branch is at a different level than the stack of the target branch. The fix for this when you're adding a new quilt patch, is to do one `quilt pop` so that the branch you're proposing for merge is at the same level as the branch you're proposing to merge into.

Aside from that, I'll note that the version of pexpect in Utopic (and Debian) is behind upstream's release on PyPI, and in fact this bug is fixed in the latest upstream release. Here's the upstream bug and diff:

http://pexpect.readthedocs.org/en/latest/history.html#releases

https://github.com/pexpect/pexpect/commit/a97f580d5cdd0f479ea64d36edc164ea769d4084 (this includes tests)

https://github.com/pexpect/pexpect/pull/38/

Since the package is team maintained in Debian, I will update it there, and that should automatically flow into Ubuntu 14.10. It's probably worth fixing this in Trusty though, so I'll file an SRU and attempt to backport the upstream fix into the Trusty branch.
--
https://code.launchpad.net/~stephane-duchesneau/ubuntu/trusty/pexpect/errno_handling_fix/+merge/218813
You are the owner of lp:~stephane-duchesneau/ubuntu/trusty/pexpect/errno_handling_fix.