Code review comment for lp:~stellarium/stellarium/tz

Revision history for this message
gzotti (georg-zotti) wrote :

When I go back to my stored location, "Use custom timezone" is disabled, but the correct TZ shown.
After restarting Stellarium, you are using correct UT+2, but location panel indicates LMST.
This is confusing. I had stored a location with custom TZ Europe/Vienna plus active DST (resulting in UTC+2). However, after reverting to default location the previously stored TZ is not again stored in config.ini, so I assume the UTC+2 comes from system settings. Still, the location panel shows LMST.

Maybe you must remember custom time zone from startup to be able to reset properly to startup location/TZ.

LMST/LTST display is fine now!

OK, I expect some user questions/complaints about some inconsistent behaviour which I described until this is fixed, but else I agree this is (going to be) much better user experience than the previous plugin-based TZ handling which required program restart. So this is the way to proceed, and yes for public testing!

review: Approve

« Back to merge proposal