Code review comment for lp:~stellarium/stellarium/tz

Revision history for this message
gzotti (georg-zotti) wrote :

New observations: Immediately after start, tooltip timezone string is not set under some circumstances. Yes, when ini:localisation:time_zone is missing because it is set to default.

I call the location panel. custom timezone disabled, DST enabled. Displayed time zone: Local Mean Solar Time. This is wrong. It could be UTC+2:00?
Still my time is correctly displayed as UTC+2:00, not LMST.
When I click on my city in the list, all is OK.
This may have to do with an "unnamed" location (just long/Lat). My startup location is not in the site list. Maybe better always store time_zone?

The "Bogota" problem is however solved. ... No, now sometimes it's the other way! Custom tz disabled, I select a city, and TZ goes to previously selected Europe/Vienna. I have to enable custom zone and disable it again to switch to the correct one. I have not found a pattern yet to trigger this confusing behaviour.

When I click a location on the map, accurate country-based timezone is not found automatically, of course. But you could simply suggest a UT+XX zone from Longitude/15, this should fit a first guess.

I have auto-location from IP query disabled. Does this also deliver a timezone?

Maybe add the longitude time offset (LMST) and equation of time value (LTST) in the tooltip? My preference would be "UT+HH:MM", "UT+HH:MM (LMST)" or "UT+HH:MM (LTST)" in the time string directly (avoid problems with tooltips not working).

review: Needs Fixing

« Back to merge proposal