Code review comment for lp:~stellarium/stellarium/textures-cleanup

Hi Georg
I tried it again on win8. This time I changed the cmakelists.txt to 1
I cleaned the build folder as before
the cmakecache txt was then automatically set to sound =1

Still no sound. just the text that accompanies it.
tested 0.12.4:- works OK

Barry

> To: <email address hidden>
> From: <email address hidden>
> Subject: RE: Sound in 0.13.0
> Date: Wed, 9 Oct 2013 11:21:39 +0000
>
> Dear Barry,
>
> I have it working on Win7.
>
> There is a nuisance in the Qt/cmake build system: In the top-level
> CMakeLists.txt, line 157, you have to SET_ENABLE_SOUND 1...
> I would have expected that re-running cmake config steps, the next build
> would include sound support. But one apparently has to clean the whole
> builds directory manually before running cmake and building the project.
> (check the logfile if in doubt whether it's activated.)
>
> With this enabled all three files play within the script.
>
> HTH, G.
>
>
> On Mi, 9.10.2013, 11:21, barrykgerdes wrote:
> > Hi Fab
> >
> >
> >
> > The standard sound test "audiotest.ssc" ,"audiotest.wav" ,"audiotest. ogg"
> > and "audiotest.mp3" as distributed with Stellarium.
> >
> > I am compiling in Windows on five different computers XP, 2x Win 7 , win 8
> > and Win 8.1. I also have a (79.4 seconds) script that plays a timelapsed
> > video of the sky from dask to dawn with background music that goes great
> > in Stellarium 0.12.4. I would love to be able to run it in 0.13.0
> >
> >
> >
> > I can't get a Linux compile to work yet. I have Qt5 installed on one
> > computer but the install program does not work on the other computers and
> > I still need to export the paths etc yet. I have not had trouble on linux
> > before, even when I had to compile Qt 4 myself.
> >
> >
> >
> > Barry
> >
> >
> >
> >
> >
> >> To: <email address hidden>
> >> From: <email address hidden>
> >> Subject: Re: Sound in 0.13.0
> >> Date: Wed, 9 Oct 2013 08:45:36 +0000
> >>
> >> Hi Barry,
> >> when I run the regular test script for sound, it works just fine on my
> >> linux computer. Which are the "old" sound test script?
> >> Fabien
> >>
> >>
> >> On Wed, Oct 9, 2013 at 5:40 AM, barrykgerdes
> >> <email address hidden>wrote:
> >>
> >> > Back in revision 6257 Fabien announced that sound was now switched to
> >> > Qmultimedia in lieu of phonon.
> >> >
> >> >
> >> >
> >> > Sound now compiles without any bother but does not play sound from any
> >> of
> >> > the old sound test scripts.
> >> >
> >> >
> >> >
> >> > Do I need to change the calls
> >> >
> >> > "core.loadSound( "file name", "type")
> >> >
> >> > "core.playSound ("type")
> >> >
> >> > "core.dropSound("type")
> >> >
> >> >
> >> >
> >> > Barry
> >> >
> >> >
> >> > >
> >> > --
> >> >
> >> > https://code.launchpad.net/~stellarium/stellarium/textures-cleanup/+merge/188775
> >> > You are subscribed to branch lp:stellarium.
> >> >
> >>
> >> --
> >> https://code.launchpad.net/~stellarium/stellarium/textures-cleanup/+merge/188775
> >> Your team Stellarium is subscribed to branch
> >> lp:~stellarium/stellarium/textures-cleanup.
> >
> > --
> > https://code.launchpad.net/~stellarium/stellarium/textures-cleanup/+merge/188775
> > Your team Stellarium is subscribed to branch
> > lp:~stellarium/stellarium/textures-cleanup.
> >
>
>
>
>
>
> --
> https://code.launchpad.net/~stellarium/stellarium/textures-cleanup/+merge/188775
> Your team Stellarium is subscribed to branch lp:~stellarium/stellarium/textures-cleanup.