Code review comment for lp:~stellarium/stellarium/ip-query-location

Revision history for this message
gzotti (georg-zotti) wrote :

Some more usability things:

config.ini, name "last_resort_location" is incomprehensible to users. Rename to last_location.

I tried: switch off LAN, start without config.ini. It loads, displays 0.00/0.00 for a second, then goes to Paris. OK.

switch on LAN, start. IP lookup, correctly displaying even place name (this time IP answer was more complete than at my place.)

restart Stellarium, name lookup of course again leads to correct display.

switch off LAN, restart Stellarium, loads coordinates of last[_resort?!]_location correctly (Location on map was OK), but displays bogus placename, consisting of degrees without any connection to the stored or used location. Name should show coordinates in this case, IMHO.

Also, I think that after the first successful IP lookup, this function should be off by default. Else we may put too much traffic onto the free service, and/or people may even complain about unwanted network traffic (?), but this is my opinion only. What do the others say?

review: Needs Fixing

« Back to merge proposal