Code review comment for lp:~stellarium/stellarium/ip-query-location

Revision history for this message
gzotti (georg-zotti) wrote :

Hmm, if

in current merge/diff display, Line 27: (defaultLocation.contains("auto"))...

consider a (existence unknown to me) a place name "Antautorina", you never know what placenames exist... ;-) --> Should be ".equals()"

One place of even greater concern, but I did not test your changes of today:

line 183: setting Last_resort_location: at this point the newly looked-up often has empty placename/country (or just IPXXX.YYY.ZZZ.AAA). On startup without IP connection and "auto" setting, this would mean looking up IPXXX.YYY.ZZZ.AAA in the location list, which will likely fail, or not? last_resort should really be that, a location guaranteed to exist in the location database. Have you tested what happens then?

review: Needs Fixing

« Back to merge proposal