Code review comment for lp:~stellarium/stellarium/deltaT-advanced

Revision history for this message
gzotti (georg-zotti) wrote :

The current solution is fine. The only distraction is that when changing DeltaT algorithm, displayed (zone) time changes. Should not matter if you just select your favorite version and save settings - on next startup all is fine. The optimal solution would IMHO be if the displayed time - and with it the sky image in the background (which depends on UT, i.e. mean solar time) - would not jump, but e.g. for solar eclipses you can target&lock the sun.
Another tiny GUI issue: One of the options of the dropdown [e.g. Espenak-Meeus (2006)] should be marked as "default".
More formulae can then be added to trunk as required. Wow, this is really unique!

review: Approve

« Back to merge proposal