Code review comment for lp:~stellarium/stellarium/deltaT-advanced

Revision history for this message
gzotti (georg-zotti) wrote :

Dear Barry,

thanks for the info. There was just a bug report on eta Car, and one of my
best shots from 2002 (slide film, hand guided, remember? ;-D happened to
have been this. What are the plans/state on DSS?

Regards,
Georg.

On Sa, 16.02.2013, 21:31, barrykgerdes wrote:
>
> Hi George
> I see you have added a nebula texture for Eta Carina
> There is already a four panel mozaic of the eta carina area that I
> provided years ago along with many others
> We originally stopped adding nebula because we were going to use DSS
> images.
> If you check the images available in the wiki you will find the package.
>
> Barry
>
>
>> To: <email address hidden>
>> From: <email address hidden>
>> Subject: Re: [Merge] lp:~stellarium/stellarium/deltaT-advanced into
>> lp:stellarium
>> Date: Sat, 16 Feb 2013 15:46:20 +0000
>>
>> Review: Needs Fixing
>>
>> In all, it looks great. However, there is still the problem that in
>> "current time/real-time" mode, the time displayed is not the system (PC
>> clock) time, but system time corrected by DeltaT. This must be fixed
>> before merge, IMHO. Small changes (docfix etc.) can be done later.
>> I also had liked the warning signs for "out of recommended range", if
>> possible.
>> I am afraid the JPL Horizons value for the present time cannot be
>> correct, and likewise Meeus&Simmons (2000), Montenbruck&Pfleger(2000).
>>
>> --
>> https://code.launchpad.net/~stellarium/stellarium/deltaT-advanced/+merge/148792
>> Your team Stellarium is requested to review the proposed merge of
>> lp:~stellarium/stellarium/deltaT-advanced into lp:stellarium.
>
> --
> https://code.launchpad.net/~stellarium/stellarium/deltaT-advanced/+merge/148792
> You are reviewing the proposed merge of
> lp:~stellarium/stellarium/deltaT-advanced into lp:stellarium.
>

« Back to merge proposal