Code review comment for lp:~stellarium/stellarium/deltaT-advanced

Revision history for this message
gzotti (georg-zotti) wrote :

In all, it looks great. However, there is still the problem that in "current time/real-time" mode, the time displayed is not the system (PC clock) time, but system time corrected by DeltaT. This must be fixed before merge, IMHO. Small changes (docfix etc.) can be done later.
I also had liked the warning signs for "out of recommended range", if possible.
I am afraid the JPL Horizons value for the present time cannot be correct, and likewise Meeus&Simmons (2000), Montenbruck&Pfleger(2000).

review: Needs Fixing

« Back to merge proposal