Code review comment for lp:~stefanor/objgraph/pure3k

Revision history for this message
Stefano Rivera (stefanor) wrote :

> I'd like Python 2.4/5 compatibility back pretty please :)

Righto, /me digs out an etch VM that has python2.4.

> Is rev. 84 necessary?

No, it isn't.

> tests need to be fixed so they actually pass!

Yeah that's one of the reasons I posted this branch now, so you could have a look and give some initial feedback, before I dived into seeing exactly what was going on in the tests.

> Incidentally, do you know any good image comparison tool, usable from the command line

I'm afraid not, looks like a niche that needs filling :P Oh, and thanks for your script, that'll be handy.

> I'm seeing spurious 2-tuples in some of the graphs

I'll have a look, but I'm doubting I can see much more than you did...

> I want the documentation text to match the images.

Agreed.

« Back to merge proposal