Code review comment for lp:~stefanor/ibid/db-import-export

Revision history for this message
Stefano Rivera (stefanor) wrote :

> Should you be loading the entire database into memory before dumping it?

Good question. For now not an issue (I assume even Spinach's DB is way smaller than the libraries he loads.

Obviously changing that would require a different file format.

> Also, what's all this "print >> stderr" stuff? Why do you use logging if
> you're not going to... use it?

The logging bit is boilerplate to get the rest of ibid to log correctly.

Standard UNIX error behaviour is error to stderr, exit non-zero.

« Back to merge proposal