Code review comment for lp:~stefan-schwarzburg/qreator/qreator_vendor_plugins

Revision history for this message
David Planella (dpm) wrote :

Nice work as usual, I like the approach.

Comments inline, just minor things:

21 + print "%s disabled due to missing vendor infrastructure." % (name,)

I wonder if we might want to use the logging system and just flag this as a warning message.

43 +

Additional whitespace here, just a nitpick, but it might be worth not introducing it.

67 + pass

Rather than passing here, do we want to perhaps print the warning in the exception as a central place, and let the plugins override the message?

review: Needs Information

« Back to merge proposal