Code review comment for ~stanley31/checkbox-support:0909_modify_audio_settings

Revision history for this message
StanleyHuang (stanley31) wrote :

Interesting, I guess it related to the python version.
I am going to take a look how does the audio_settings scripts works in trusty and xenial (with default python environment.

> Hmmm I'm wondering why they are passing for you because I'm seeing:
>
> ======================================================================
> ERROR: test_volume_regex_trusty
> (checkbox_support.scripts.tests.test_audio_settings.RegexTest)
> Testing pactl 4.0 output
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/ubuntu/host/checkbox-project/checkbox-
> support/checkbox_support/scripts/tests/test_audio_settings.py", line 179, in
> test_volume_regex_trusty
> volume_regex = re.compile(volume_pattern % "0", re.DOTALL)
> TypeError: not all arguments converted during string formatting
>
> ======================================================================
> ERROR: test_volume_regex_xenial
> (checkbox_support.scripts.tests.test_audio_settings.RegexTest)
> Testing pactl 8.0 output
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/ubuntu/host/checkbox-project/checkbox-
> support/checkbox_support/scripts/tests/test_audio_settings.py", line 187, in
> test_volume_regex_xenial
> volume_regex = re.compile(volume_pattern % "front-left", re.DOTALL)
> TypeError: not all arguments converted during string formatting

« Back to merge proposal