Checkbox Support Library

Code review comment for ~stanley31/checkbox-support:0909_modify_audio_settings

  1. Git
  2. lp:~stanley31/checkbox-support
  3. 0909_modify_audio_settings
  4. Merge into master
Revision history for this message
Jonathan Cave (jocave) wrote :

Hmmm I'm wondering why they are passing for you because I'm seeing:

======================================================================
ERROR: test_volume_regex_trusty (checkbox_support.scripts.tests.test_audio_settings.RegexTest)
Testing pactl 4.0 output
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/host/checkbox-project/checkbox-support/checkbox_support/scripts/tests/test_audio_settings.py", line 179, in test_volume_regex_trusty
    volume_regex = re.compile(volume_pattern % "0", re.DOTALL)
TypeError: not all arguments converted during string formatting

======================================================================
ERROR: test_volume_regex_xenial (checkbox_support.scripts.tests.test_audio_settings.RegexTest)
Testing pactl 8.0 output
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/host/checkbox-project/checkbox-support/checkbox_support/scripts/tests/test_audio_settings.py", line 187, in test_volume_regex_xenial
    volume_regex = re.compile(volume_pattern % "front-left", re.DOTALL)
TypeError: not all arguments converted during string formatting

« Back to merge proposal