Code review comment for ~stanley31/checkbox-support:0909_modify_audio_settings

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Great stuff! Thank you for all the patches. As for which string interpolation option, I think .format() is great. One thing to note, though, is for logging calls the %s should be used, as this prevents formatting from happening unless the logging call is on the right level (it's evaluated lazily). You can read more here: https://stackoverflow.com/questions/34619790/pylint-message-logging-format-interpolation

I'm +1 on landing this.

review: Approve

« Back to merge proposal