Code review comment for ~stanley31/checkbox-support:0909_modify_audio_settings

Revision history for this message
Maciej Kisielewski (kissiel) wrote :

I found one problem with the regex string, see below.

Nitpicking: There are at least three ways that string interpolation is used in this code (overall audio_settings.py, not just your patch):
+
.format
""%()

And I think it's pretty yucky. I'm not asking anyone to do a small revolution and fix all that, but I would prefer not to cultivate bad habits.

review: Needs Fixing

« Back to merge proposal