Hello Adam,
> I don't have time to review and merge right now, but the changes look correct and I will merge as soon as I can and definitely before the next release (since functional analysis without the Hahn-Banach theorem won't get you very far). Just a small thing, could you revert the usage of "QUrl::fromLocalFile" since that is not available on Qt 4.6 which we are currently still targeting. Thanks!
It feels good to see a man of computer's world knows about mathematics's world.
Sorry again unrelated discussions:
1- I suggest that the HelpDialog should be non-modal, then user can read it and test application without closing it.
2- I want to save firstPage state to database (indeed I wrote the patch) but I don't understand the following part of preparePerFileSettings_v2()?
if(Settings::instance()->mainWindow().restorePerFileSettings())
{ query.exec("DELETE FROM perfilesettings_v2 WHERE filePath IN (SELECT filePath FROM perfilesettings_v2 ORDER BY lastUsed DESC LIMIT -1 OFFSET 1000)");
}
else
{ query.exec("DELETE FROM perfilesettings_v2");
}
Hello Adam, fromLocalFile" since that is not available on Qt 4.6 which we are currently still targeting. Thanks!
> I don't have time to review and merge right now, but the changes look correct and I will merge as soon as I can and definitely before the next release (since functional analysis without the Hahn-Banach theorem won't get you very far). Just a small thing, could you revert the usage of "QUrl::
It feels good to see a man of computer's world knows about mathematics's world.
Sorry again unrelated discussions: ettings_ v2()?
1- I suggest that the HelpDialog should be non-modal, then user can read it and test application without closing it.
2- I want to save firstPage state to database (indeed I wrote the patch) but I don't understand the following part of preparePerFileS
if( Settings: :instance( )->mainWindow( ).restorePerFil eSettings( ))
query. exec("DELETE FROM perfilesettings_v2 WHERE filePath IN (SELECT filePath FROM perfilesettings_v2 ORDER BY lastUsed DESC LIMIT -1 OFFSET 1000)");
query. exec("DELETE FROM perfilesettings _v2");
{
}
else
{
}
Best Regards,
Razi.