Code review comment for lp:~srazi/qpdfview/small-patches

Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello Razi,

I don't have time to review and merge right now, but the changes look correct and I will merge as soon as I can and definitely before the next release (since functional analysis without the Hahn-Banach theorem won't get you very far). Just a small thing, could you revert the usage of "QUrl::fromLocalFile" since that is not available on Qt 4.6 which we are currently still targeting. Thanks!

Best regards, Adam.

review: Approve

« Back to merge proposal