> * I think BookmarkDialog::appendComment should become Bookmark::append since it is not involved with the presentation layer at all.
I agree.
> * The text rendering code of BookmarkItemDelegate seems to have quite a bit of duplication with e.g. SearchItemDelegate. Could this be factored out into some common text rendering code? Can we not somehow reuse the existing text rendering used to e.g. draw QLabel?
Yes, indeed it is a modified copy of SearchItemDelegate. Good idea, I will try to refactor it.
Hello,
> * I think BookmarkDialog: :appendComment should become Bookmark::append since it is not involved with the presentation layer at all.
I agree.
> * The text rendering code of BookmarkItemDel egate seems to have quite a bit of duplication with e.g. SearchItemDelegate. Could this be factored out into some common text rendering code? Can we not somehow reuse the existing text rendering used to e.g. draw QLabel?
Yes, indeed it is a modified copy of SearchItemDelegate. Good idea, I will try to refactor it.
Best Regards,
Razi.