Code review comment for lp:~spud/spud/syntaxhighlighting

I think the "language" attribute is used for the .xml test_options.rng schema. Not in the spud base language indeed, so more a schema specific hack. So do we want to change the .xml specification as well? I guess it wasn't really written with spud in mind. It might be nice to keep the current check as a transitional thing (if we do decide to change .xml)

Is it the case that diamond will be able to handle this smoothly when handling old flmls? As in, would it simply change the attributes when opening up, without loosing any elements? In that case, yes a simple transition script should be fine. I presume spud itself doesn't really care about the attributes, and just treats it as a string?

I agree this is probably not something we want to push through before the release. If we do it after, we also have to make sure the updated diamond still works correctly when using the release schema (with the old python_code definition).

But in general: a useful addition.