Code review comment for lp:~spud/spud/syntaxhighlighting

Revision history for this message
Patrick Farrell (pefarrell) wrote :

I think syntax highlighting of other languages is desirable and important, so thanks for the contribution.

I agree with you: I think the self.get_attr("language") did nothing. It is probably a leftover from some previous way of denoting python code in the schema; I think you are correct in deleting it.

I think that if you're going to change the schema in such a way that a currently valid flml becomes invalid, then you should write a script that converts from type == "python" to (type, language) == ("code", "python"). I'm not sure how to manage the transition, and I'm not sure we'd want this to go in before release. David, Stephan, any thoughts?

« Back to merge proposal