Merge lp:~spud/spud/diamond-schema-remove-gdk into lp:spud
Proposed by
Tim Greaves
| Status: | Merged |
|---|---|
| Merged at revision: | 515 |
| Proposed branch: | lp:~spud/spud/diamond-schema-remove-gdk |
| Merge into: | lp:spud |
| Diff against target: |
11 lines (+0/-1) 1 file modified
diamond/diamond/schema.py (+0/-1) |
| To merge this branch: | bzr merge lp:~spud/spud/diamond-schema-remove-gdk |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Ham | Approve | ||
|
Review via email:
|
|||
Description of the change
When using diamond purely as a validation tool to check options files, diamond.schema can be imported in environments which don't have a display but do have gtk.gdk. An example of this would be the diamond_validation test case in Fluidity.
As far as I can see there is no need to import gtk.gdk in diamond.schema as it's not used, and removing it doesn't appear to break anything. It would be very handy if this could be removed, so that headless systems can still use diamond.schema for validation.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Good idea. If it were needed it would be obvious in the code.