Code review comment for lp:~spud/spud/alias

Revision history for this message
Fraser Waters (fraser-waters08) wrote :

> I guess -s would override -a if in doubt. But since this is an assumption that
> is not clear to the user I think raising an error is preferred.

What about pointing it out in the help and raising a warning if both are set. I'm just wondering if people might shortcut their diamond to use one alias normally and then add -s sometimes to load a file? Is that a valid use case?

> I agree with s-kramer that any "legal" file name should be allowed.

Yes in hind sight it wasn't a good idea to try and differentiate on one option.

> Just a thought I had the other day: bzr branches (can) have a nickname you can
> read and set with `bzr nick` (it is automatically set if you `bzr branch`). In
> case neither -a nor -s are given, diamond could try using the bzr nick to
> auto-select the alias. In case bzr nick is not available (i.e. you're not
> running diamond from within a bzr branch) it could go back to the defaults.

If others agree I'm sure it can be put in.

« Back to merge proposal