Code review comment for lp:~springfield-team/charms/trusty/nova-cloud-controller/next

Ok first an apology. I was incorrect to say that we could meld the cisco_plugins.ini files for havana and Icehouse since if you run Icehouse the template engine will not look further than templates/havana so your last commit was not required (and would break havana n1kv). Now, upon further inspection and discussion there are a few other issues here:

1. neutron-server support in the nova-cloud-controller charm is being deprecated and has been shifted to the neutron-api charm (lp:~openstack-charmers/charms/trusty/neutron-api/next). So we cannot accept new neutron features/functionality for this charm (neutron-api charm already has some features that do not exist here e.g. neutron l2 population support).

2. Also, this patch is adding support for Havana and Icehouse but Havana is no longer supported in the charms (same as earlier versions) - see https://wiki.ubuntu.com/ServerTeam/CloudArchive for more info on what releases are supported. So this patch will need to be constrained to Icehouse and Juno.

So apologies for not pointing this out earlier but I'll have to reject this patch and request it be moved to neutron-api. It would also be nice to have a test deployer (e.g. added to https://code.launchpad.net/~openstack-charm-testers) to give me some idea of how you propose to deploy n1kv so I can try it out (without cisco hardware it should still be possible to deploy this and check that config files have the correct settings etc).