Code review comment for lp:~springfield-team/charms/trusty/nova-cloud-controller/next

UOSCI bot says:
This MP triggered a test on the Ubuntu OSCI system. Here is a summary of results.

#462 nova-cloud-controller-next for shivrao mp235182
charm_unit_test

This build:
http://10.98.191.181:8080/job/charm_unit_test/462/

MP URL:
https://code.launchpad.net/~springfield-team/charms/trusty/nova-cloud-controller/next/+merge/235182

Proposed branch:
lp:~springfield-team/charms/trusty/nova-cloud-controller/next

Results summary:
    UNIT OK: believed to pass, but you should confirm results

UNIT Results (max last 25 lines) from
/var/lib/jenkins/workspace/charm_unit_test/unit-test.462:
Ensure services with incomplete interfaces are stopped ... ok
Ensure services with complete interfaces are not stopped ... ok
Ensure that if disabled, service guards nothing ... ok
test_ssh_authorized_key_doesnt_exist (unit_tests.test_nova_cc_utils.NovaCCUtilsTests) ... ok
test_ssh_authorized_key_exists (unit_tests.test_nova_cc_utils.NovaCCUtilsTests) ... ok
test_ssh_compute_remove (unit_tests.test_nova_cc_utils.NovaCCUtilsTests) ... ok
test_ssh_directory_for_unit (unit_tests.test_nova_cc_utils.NovaCCUtilsTests) ... ok
test_ssh_known_host_key (unit_tests.test_nova_cc_utils.NovaCCUtilsTests) ... ok
Simulate a call to do_openstack_upgrade() for grizzly->icehouse ... ok
Verify get_step_upgrade_source() for grizzly->icehouse ... ok
Simulate a call to do_openstack_upgrade() for havana->icehouse ... ok
Simulate a call to do_openstack_upgrade() for havana->icehouse api ... ok
Verify get_step_upgrade_source() for havana->icehouse ... ok

Name Stmts Miss Cover Missing
-----------------------------------------------------
hooks/nova_cc_context 139 100 28% 21-28, 39-41, 47-61, 68-86, 98-151, 162-177, 185-186, 190, 194-196, 201, 204-218, 224-238, 255-258, 263-265
hooks/nova_cc_hooks 424 151 64% 131-134, 147-148, 172, 182-190, 221, 226-231, 242, 319-322, 330-333, 339-342, 352-368, 377-379, 389-403, 407-416, 502, 512, 516-517, 570, 576-586, 591-602, 612-622, 627-666, 676-691, 699-703, 716, 726-735, 759, 764-772, 820-823
hooks/nova_cc_utils 442 111 75% 292-297, 308-311, 321-322, 378, 380, 424-426, 430, 444-452, 459-464, 468-482, 588-590, 595-598, 603, 607, 631-632, 646-648, 669-670, 676-699, 703-709, 713-719, 725, 731, 738, 749-753, 838, 898-904, 908-910, 914-917, 921-933
-----------------------------------------------------
TOTAL 1005 362 64%
----------------------------------------------------------------------
Ran 90 tests in 10.250s

OK

Ubuntu OSCI Jenkins is currently in development on a Canonical private network, but we plan to publish results to a public instance soon. Tests are triggered if the proposed branch rev changes, or if the MP is placed into "Needs review" status after being otherwise for >= 1hr. Human review of results is still recommended.
http://10.98.191.181:8080/