Code review comment for lp:~springfield-team/charm-helpers/trunk

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

OK, i slightly modified the source to complain a failing test.

======================================================================
FAIL: test_neutron_n1kv_plugin_context (tests.contrib.openstack.test_os_contexts.ContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1210, in patched
    return func(*args, **keywargs)
  File "/home/niedbalski/src/juju/charms/charm-helpers/tests/contrib/openstack/test_os_contexts.py", line 1506, in test_neutron_n1kv_plugin_context
    }, neutron.n1kv_ctxt())
AssertionError: {'vsm_username': 'n1kv', 'neutron_security_groups': True, 'vsm_ip': 'n1kv', 'res [truncated]... != {'vsm_username': 'n1kv', 'neutron_security_groups': True, 'user_config_flags': { [truncated]...
  {'config': 'some.quantum.driver.class',
   'core_plugin': 'some.quantum.driver.class',
   'local_ip': '10.0.0.1',
   'neutron_plugin': 'n1kv',
   'neutron_security_groups': True,
   'restrict_policy_profiles': 'n1kv',
+ 'user_config_flags': {},
   'vsm_ip': 'n1kv',
   'vsm_password': 'n1kv',
   'vsm_username': 'n1kv'}

Other than that, looks good to me.

review: Approve

« Back to merge proposal