OK, i slightly modified the source to complain a failing test.
====================================================================== FAIL: test_neutron_n1kv_plugin_context (tests.contrib.openstack.test_os_contexts.ContextTests) ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/mock.py", line 1210, in patched return func(*args, **keywargs) File "/home/niedbalski/src/juju/charms/charm-helpers/tests/contrib/openstack/test_os_contexts.py", line 1506, in test_neutron_n1kv_plugin_context }, neutron.n1kv_ctxt()) AssertionError: {'vsm_username': 'n1kv', 'neutron_security_groups': True, 'vsm_ip': 'n1kv', 'res [truncated]... != {'vsm_username': 'n1kv', 'neutron_security_groups': True, 'user_config_flags': { [truncated]... {'config': 'some.quantum.driver.class', 'core_plugin': 'some.quantum.driver.class', 'local_ip': '10.0.0.1', 'neutron_plugin': 'n1kv', 'neutron_security_groups': True, 'restrict_policy_profiles': 'n1kv', + 'user_config_flags': {}, 'vsm_ip': 'n1kv', 'vsm_password': 'n1kv', 'vsm_username': 'n1kv'}
Other than that, looks good to me.
« Back to merge proposal
OK, i slightly modified the source to complain a failing test.
======= ======= ======= ======= ======= ======= ======= ======= ======= ======= n1kv_plugin_ context (tests. contrib. openstack. test_os_ contexts. ContextTests) ------- ------- ------- ------- ------- ------- ------- ------- ------- python2. 7/dist- packages/ mock.py" , line 1210, in patched niedbalski/ src/juju/ charms/ charm-helpers/ tests/contrib/ openstack/ test_os_ contexts. py", line 1506, in test_neutron_ n1kv_plugin_ context n1kv_ctxt( )) security_ groups' : True, 'vsm_ip': 'n1kv', 'res [truncated]... != {'vsm_username': 'n1kv', 'neutron_ security_ groups' : True, 'user_config_ flags': { [truncated]... driver. class', driver. class', plugin' : 'n1kv', security_ groups' : True, policy_ profiles' : 'n1kv', flags': {},
FAIL: test_neutron_
-------
Traceback (most recent call last):
File "/usr/lib/
return func(*args, **keywargs)
File "/home/
}, neutron.
AssertionError: {'vsm_username': 'n1kv', 'neutron_
{'config': 'some.quantum.
'core_plugin': 'some.quantum.
'local_ip': '10.0.0.1',
'neutron_
'neutron_
'restrict_
+ 'user_config_
'vsm_ip': 'n1kv',
'vsm_password': 'n1kv',
'vsm_username': 'n1kv'}
Other than that, looks good to me.