Code review comment for lp:~spiv/meliae/frame-info

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Andrew Bennetts has proposed merging lp:~spiv/meliae/frame-info into lp:meliae.
>
> Requested reviews:
> Meliae Development Team (meliae-dev)
>
>
> I haven't tested it does what I expect, but it compiles and passes tests, and it *looks* plausible...
>

I went ahead and wrote a test that used sys._get_frame().

 merge: approve

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkw7eRUACgkQJdeBCYSNAAP0LwCeKMkmKUTRPIOP6DS17yah+sru
YKsAoJzZMEliONezDHFRsZtJlMFOf9Jq
=fhK5
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal