Code review comment for lp:~spiv/bzr/win-serve-error

Andrew Bennetts (spiv) wrote :

Robert Collins wrote:
[...]
> How about
[...]
> + if e.args[0] in (errno.ECONNRESET, 10054):
> + # The connection was closed by the other side.
> + bytes = ''
[...]
> This avoids having a different code path exiting the function and may
> scale better as other cases need to be caught.

Yeah, that's better. Thanks!

-Andrew.

« Back to merge proposal