Bazaar

Merge lp:~spiv/bzr/trivial-pack1.9 into lp:~bzr/bzr/trunk-old

  1. trivial-pack1.9
  2. Merge into trunk-old
Proposed by Andrew Bennetts
Status: Merged
Merged at revision: not available
Proposed branch: lp:~spiv/bzr/trivial-pack1.9
Merge into: lp:~bzr/bzr/trunk-old
Diff against target: 21 lines
To merge this branch: bzr merge lp:~spiv/bzr/trivial-pack1.9
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Review via email: mp+7664@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrew Bennetts (spiv) wrote :

This is pretty trivial :)

I just happened to notice this FIXME comment in passing, did the obvious fix
and ran a test suite in a quiet moment, and it passed. So here's the patch.

Revision history for this message
Robert Collins (lifeless) wrote :

 review +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'bzrlib/revision.py'
--- bzrlib/revision.py 2009-04-06 21:01:10 +0000
+++ bzrlib/revision.py 2009-06-19 04:35:12 +0000
@@ -68,7 +68,6 @@
68 def __eq__(self, other):68 def __eq__(self, other):
69 if not isinstance(other, Revision):69 if not isinstance(other, Revision):
70 return False70 return False
71 # FIXME: rbc 20050930 parent_ids are not being compared
72 return (71 return (
73 self.inventory_sha1 == other.inventory_sha172 self.inventory_sha1 == other.inventory_sha1
74 and self.revision_id == other.revision_id73 and self.revision_id == other.revision_id
@@ -76,7 +75,8 @@
76 and self.message == other.message75 and self.message == other.message
77 and self.timezone == other.timezone76 and self.timezone == other.timezone
78 and self.committer == other.committer77 and self.committer == other.committer
79 and self.properties == other.properties)78 and self.properties == other.properties
79 and self.parent_ids == other.parent_ids)
8080
81 def __ne__(self, other):81 def __ne__(self, other):
82 return not self.__eq__(other)82 return not self.__eq__(other)