Code review comment for lp:~spiv/bzr/rename-init_ex-verb

Revision history for this message
Robert Collins (lifeless) wrote :

On Fri, 2009-06-12 at 02:15 +0000, Martin Pool wrote:
> Review: Approve
> I didn't follow the discussion in detail but the patch and reasoning seems ok. I presume you manually tested against an older server?
>
> I think we're getting to the point where we should accept reality and just make the client and server know each other's versions. Just going by actual capabilities is very nice in theory, but it's not what we actually do. Guessing the version from the capabilities is the worst of both.

FWIW version numbers in the client wouldn't have helped; They may have
helped in the server, but it would have been complex given our code
structure.

-Rob

« Back to merge proposal