Bazaar

Code review comment for lp:~spiv/bzr/no-sigwinch-583941

  1. no-sigwinch-583941
  2. Merge into 2.1
Revision history for this message
Martin Pool (mbp) wrote :

That looks nice.

I'd like to check that running eg that log command does not take any longer with this patch.

I guess you can work out with vila what to do under emacs. I would guess that the ioctl just does not work there and so it's enough to use $COLUMNS if the ioctl fails, but it may be more complicated. Perhaps we can add a big comment about this.

review: Approve

« Back to merge proposal