Bazaar

Code review comment for lp:~spiv/bzr/lockcontention-pushing-tag-733350-2.3

  1. lockcontention-pushing-tag-733350-2.3
  2. Merge into 2.3
Revision history for this message
Martin Pool (mbp) wrote :

PEP8: docstrings ought to have just one sentence on the first line. (I guess you accidentally reflowed them.)

Thanks for fixing this and for the clear cover letter. It makes sense to me.

I'd like a docstring mention for the new ivar.

You may want to wait for a second review in case someone knows of problem consequences.

(tweak)

review: Approve

« Back to merge proposal