Code review comment for lp:~spiv/bzr/import-tariff-test-subprocess-deadlock
Revision history for this message
| Vincent Ladeuil (vila) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
Rejoice !
The plan was good ! The implementation... missed a tiny tiny little bit :)
I even wonder what happened there, I can only suspect you tested it successfully on the failing test, tried all import tests, realized one was broken, fixed it... without realizing you broke the first one ;)
But anyway, well done !
The missing tiny little bit is at lp:~vila/bzr/import-tariff-test-subprocess-deadlock which I will land, because that will be a nice way to end the week !
The war is over ! This bug is dead !