Code review comment for lp:~spiv/bzr/import-tariff-test-subprocess-deadlock

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/27/2011 10:15 AM, John A Meinel wrote:
> On 05/27/2011 09:48 AM, Vincent Ladeuil wrote:
>> Confirmed, still hanging on OSX :-/
>
> Can we use a temporary file instead of a file in the current directory?
> Otherwise I think this is better than before, regardless of whether it
> makes the specific bits better.
>
> John
> =:->
>

I take that back. I think the test is already isolated in a temp dir,
just using a local file is fine.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk3fXfoACgkQJdeBCYSNAAMEswCdE2bXxwtUiw5OUt3W270Ghskx
pEYAn1aVf4WNQZBKqPhUCA4cY3NO7lnL
=jwFN
-----END PGP SIGNATURE-----

« Back to merge proposal