Code review comment for lp:~spiv/bzr/fetch-spec-everything-not-in-other

I think it would be worth adding docstrings on AbstractSearchResult and SearchResult because the names are suggestive but not self-explanatory. The docstrings on the members are good. It is pretty well covered in your document (https://code.launchpad.net/~spiv/bzr/fetch-dev-docs/+merge/46053) so a sentence or two should be enough.

+ if symbol_versioning.deprecated_passed(revision_id):
+ symbol_versioning.warn(
+ 'search_missing_revision_ids(revision_id=...) was '
+ 'deprecated in 2.3. Use revision_ids=[...] instead.',
+ DeprecationWarning, stacklevel=2)

That will now be 2.4. It seems like we ought to have common handling of deprecated parameters. (https://bugs.launchpad.net/bzr/+bug/712922) And there's a couple more.

merge-with-tweaks

Thanks, and sorry for the delay.