Merge lp:~spiv/bzr-builddeb/unbound-local-623736 into lp:bzr-builddeb
Proposed by
Andrew Bennetts
Status: | Rejected |
---|---|
Rejected by: | James Westby |
Proposed branch: | lp:~spiv/bzr-builddeb/unbound-local-623736 |
Merge into: | lp:bzr-builddeb |
Diff against target: |
23 lines (+7/-6) 1 file modified
bzrtools_import.py (+7/-6) |
To merge this branch: | bzr merge lp:~spiv/bzr-builddeb/unbound-local-623736 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Westby | Disapprove | ||
Review via email: mp+33609@code.launchpad.net |
Description of the change
This should fix an UnboundLocalError in the case where file_ids_from is an empty list.
I took a look at writing a test, but I couldn't find unit tests for the bzrtools_import functions, and I'm not sure how to provoke that situation via less direct APIs. I can at least say it doesn't break any tests :)
To post a comment you must log in.
Unmerged revisions
- 476. By Andrew Bennetts
-
Fix UnboundLocalError in _import_archive.
If you look back a few commits in the file you'll see a change by me;
that commit has tests.
-Rob