Code review comment for lp:~spiv/bzr-builddeb/unbound-local-623736

James Westby (james-w) wrote :

On Wed, 25 Aug 2010 05:20:55 -0000, Andrew Bennetts <email address hidden> wrote:
> Andrew Bennetts has proposed merging lp:~spiv/bzr-builddeb/unbound-local-623736 into lp:bzr-builddeb.
>
> Requested reviews:
> Bzr-builddeb-hackers (bzr-builddeb-hackers)
> Related bugs:
> #623736 bzr crashed with UnboundLocalError in _import_archive()
> https://bugs.launchpad.net/bugs/623736
>
>
> This should fix an UnboundLocalError in the case where file_ids_from
> is an empty list.

Thanks.

> I took a look at writing a test, but I couldn't find unit tests for
> the bzrtools_import functions, and I'm not sure how to provoke that
> situation via less direct APIs. I can at least say it doesn't break
> any tests :)

Feel free to add a TestCase for testing bzrtools_import directly. That
would seem to be the best thing here.

It shouldn't be hard to set up the conditions, as you can import a
directory, and file_ids_from is just passed in directly.

Let me know if you would like me to do it.

Thanks,

James

« Back to merge proposal