Merge lp:~spacefarmer/appcenter/simplelabels into lp:~elementary-apps/appcenter/appcenter

Proposed by Greg Holkenbrink
Status: Merged
Approved by: Artem Anufrij
Approved revision: 309
Merged at revision: 312
Proposed branch: lp:~spacefarmer/appcenter/simplelabels
Merge into: lp:~elementary-apps/appcenter/appcenter
Diff against target: 24 lines (+3/-3)
1 file modified
src/Core/ChangeInformation.vala (+3/-3)
To merge this branch: bzr merge lp:~spacefarmer/appcenter/simplelabels
Reviewer Review Type Date Requested Status
Artem Anufrij (community) Approve
Review via email: mp+306724@code.launchpad.net

Commit message

Changed labels:
"Downloading packages", "Installing packages", and "Waiting in queue" to "Downloading", "Installing", and "Waiting"

Description of the change

Updated progress bar label strings to proposed simpler ones per: https://bugs.launchpad.net/appcenter+bug/1612501

"Downloading packages", "Installing packages", and "Waiting in queue" to "Downloading", "Installing", and "Waiting"

Tested by building and installing, reboot, then installing an app. Required a reboot before changes took effect.

To post a comment you must log in.
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Functiont: tested -> ok
Code style: ok

review: Approve
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

No conflicts with trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/Core/ChangeInformation.vala'
--- src/Core/ChangeInformation.vala 2016-08-25 10:12:06 +0000
+++ src/Core/ChangeInformation.vala 2016-09-26 00:45:56 +0000
@@ -46,7 +46,7 @@
46 case Pk.Status.SETUP:46 case Pk.Status.SETUP:
47 return _("Starting");47 return _("Starting");
48 case Pk.Status.WAIT:48 case Pk.Status.WAIT:
49 return _("Waiting in queue");49 return _("Waiting");
50 case Pk.Status.RUNNING:50 case Pk.Status.RUNNING:
51 return _("Running");51 return _("Running");
52 case Pk.Status.QUERY:52 case Pk.Status.QUERY:
@@ -56,9 +56,9 @@
56 case Pk.Status.REMOVE:56 case Pk.Status.REMOVE:
57 return _("Removing packages");57 return _("Removing packages");
58 case Pk.Status.DOWNLOAD:58 case Pk.Status.DOWNLOAD:
59 return _("Downloading packages");59 return _("Downloading");
60 case Pk.Status.INSTALL:60 case Pk.Status.INSTALL:
61 return _("Installing packages");61 return _("Installing");
62 case Pk.Status.REFRESH_CACHE:62 case Pk.Status.REFRESH_CACHE:
63 return _("Refreshing software list");63 return _("Refreshing software list");
64 case Pk.Status.UPDATE:64 case Pk.Status.UPDATE:

Subscribers

People subscribed via source and target branches