Code review comment for lp:~soren/nova/secgroup-fixes

Revision history for this message
Soren Hansen (soren) wrote :

> This is good, although it might be nice to show both source groups with a
> specific protocol and without. Seems like it could be accomplished with
> another if inside the if rule.group_id:
>
> if rule.protocol:
> # show one rule
> else:
> # show three rules
>
> Thoughts?

Depends. Do we want to allow source group filters with protocols and ports and stuff if EC2 doesn't?

« Back to merge proposal