OpenStack Compute (nova)

Code review comment for lp:~soren/nova/iptables-security-groups

  1. iptables-security-groups
  2. Merge into trunk
Revision history for this message
Vish Ishaya (vishvananda) wrote :

Minor issue:

171 options(joinedload('security_groups')).\
172 + options(joinedload_all('security_groups.rules')).\

joinedload_all will load all of the objects in the chain so lines 171 and 179 are redundant and can be removed.

Also, have you tested with --use_nova_chains as well?

Finally, do you think that the we be iptables security groups is strictly superior to nwfilter security groups? Should we continue to support the other driver or deprecate it?

review: Needs Fixing

« Back to merge proposal