Code review comment for lp:~soren/nova/iptables-concurrency

Revision history for this message
Vish Ishaya (vishvananda) wrote :

The rules seem to be working correctly now. One final suggestion:

The SNATTING chain is user created. I capitalized it originally because all of the default chains are capitalized. Now that we are using it along with a bunch of other custom chains (like floating-snat), i'm thinking for consistency it should be "snatting" or even "snat".

I'll go ahead and approve and leave it up to you if you want to change it.

review: Approve

« Back to merge proposal