Code review comment for lp:~soren/nova/fix-unittest

Revision history for this message
Soren Hansen (soren) wrote :

2011/2/15 Ed Leafe <email address hidden>:
> This might be cleaner:
>
> group = [grp for grp in rv if grp.name == security_group_name][0]
>
> It eliminates the iteration loop, and would have avoided the problem in the first place.

Yup, looks good. Thanks.

--
Soren Hansen        | http://linux2go.dk/
Ubuntu Developer    | http://www.ubuntu.com/
OpenStack Developer | http://www.openstack.org/

« Back to merge proposal